fix: allow for in-source-config internal edge functions in proxy #5311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 6214768 Package size: 242 MB(no change) Legend
|
eduardoboucas
approved these changes
Dec 14, 2022
| } catch { | ||
| return { | ||
| functions: [], | ||
| path: null, |
Member
There was a problem hiding this comment.
If we wanted to be a bit more consistent, we could make path: undefined here and then in src/lib/edge-functions/proxy.mjs make the check:
const hasEdgeFunctions = userFunctionsPath !== undefined || internalFunctionsPath !== undefinedNot a huge deal, though.
khendrikse
deleted the
fix/fix-in-source-config-internal-edge-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Should fix an issue where having any internal functions with in-source-config, but no other edge functions, would prevent the proxy from running the internal EF.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)